Subject: Re: Support for new links in megatools 1.10.2
From: Ondřej Jirman
Date: Wed, 15 Apr 2020 12:28:56 +0200
On Wed, Apr 15, 2020 at 12:16:50PM +0200, Alberto Garcia wrote:
> On Wed, Apr 15, 2020 at 12:11:27PM +0200, Ondřej Jirman wrote:
> > > Does the patch that I'm attaching look ok? (it took me a minute to
> > > write it, don't expect anything very spectacular :))
> > A small problem with that patch is that glib does allocate m1 even
> > on failed match. Anyway, looking at the glib code, that will just
> > produce a small memleak and nothing serious. I wouldn't worry about
> > it. Otherwise, it looks fine.
> Oh, I see. I suppose it's not so important since we're leaking all
> GRegex objects anyway?
GRegex objects are auto-freed (see gc_regex_unref).
Anyway, don't worry about it. It will be around 100B'ish per command line
argument, at maximum.
I've released a new tarball for 1.10.3 with your patch.